Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make completion depth adjustable #266

Open
TomerBG2 opened this issue Jun 12, 2020 · 5 comments
Open

Make completion depth adjustable #266

TomerBG2 opened this issue Jun 12, 2020 · 5 comments

Comments

@TomerBG2
Copy link

When running widget -- --completion you can't control the depth variable.
Currently it's set to 3 by default and you cant change it using the CLI.

@dbieber
Copy link
Member

dbieber commented Jun 12, 2020

Hi @TomerBG2,
What is your use case for wanting to adjust the depth?

@TomerBG2
Copy link
Author

TomerBG2 commented Jun 12, 2020

Hi @dbieber ,
When using fire (with entry point) on an object consisting of a lot of sub-objects, the generated bash completion stops at the depth of 3. So lets say I have the following:

A
    B
        C
            D
                E
                    get_x()
                    set_x(val)

Currently you only get tab completion until the C object, after that you have press enter and see what commands are available. I can think of two ways to solve this issue, using the interactive shell but this way it's not an entry point script anymore, or making the depth variable configurable upon running the --completion option.

I've opened a pull request, #267

@DvirB10
Copy link

DvirB10 commented Jun 30, 2020

Hi @dbieber!

Any updates on this issue? Thanks! :)

@asafkahlon
Copy link

Hello @dbieber, is there any chance to merge #267 soon?
Thanks!

@TomerBG2
Copy link
Author

@dbieber Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants