Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowgraph call count needs cleanup #2003

Open
philburk opened this issue Apr 26, 2024 · 0 comments
Open

Flowgraph call count needs cleanup #2003

philburk opened this issue Apr 26, 2024 · 0 comments
Assignees

Comments

@philburk
Copy link
Collaborator

philburk commented Apr 26, 2024

We may be able to eliminate the need for mInputCallCount variable if we define:

/***************************************************************************/
int32_t FlowGraphPortFloatInput::pullData(int32_t numFrames) {
    return (mConnected == nullptr)
            ? std::min(getFramesPerBuffer(), numFrames)
            : mConnected->pullData(mConnected.getLastCallCount() + 1, numFrames); // use existing callcount
}

and call that from SampleRateConverter::isInputAvailable()

Argument order is inconsistent:

int32_t FlowGraphNode::pullData(int32_t numFrames, int64_t callCount) {
vs
int32_t FlowGraphPortFloatOutput::pullData(int64_t callCount, int32_t numFrames) {

Argument name does not match! framePosition != callCount

int32_t pullData(int64_t framePosition, int32_t numFrames) override;
@philburk philburk self-assigned this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant