Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libre Franklin italic, left double quote is distorted #2062

Closed
Scott-N opened this issue Jul 9, 2019 · 7 comments
Closed

Libre Franklin italic, left double quote is distorted #2062

Scott-N opened this issue Jul 9, 2019 · 7 comments

Comments

@Scott-N
Copy link

Scott-N commented Jul 9, 2019

This was reported two years ago on the font designer's github, here, and reportedly fixed at the time. But I just started using the font, and the distorted left-double-quote is still there. The two inverted commas of the left-double-quote (“) are overlapping rather than spaced apart from each other.)

The most affected faces are...

  • Libre Franklin Light Italic
  • Libre Franklin Regular Italic
  • Libre Franklin Medium Italic
  • Libre Franklin Semi-Bold Italic
  • Libre Franklin Bold Italic

(Extra-Light Italic and Extra-Bold Italic are slightly affected. Thin Italic and Black Italic are fine.)

You can see for yourself by copying the left-double-quote from the character list (next to the exclamation point) and pasting it into the preview text field on the GF specimen page, here.

@thomaus
Copy link

thomaus commented Feb 22, 2020

Looks like the repaired versions are still not loaded.
The “ are still showing as distorted on italics on the specimen page:

Screenshot 2020-02-22 13 26 11

Note this is not the " character, instead it’s the “ character. (option-[ on the Mac)

@pichotta
Copy link

pichotta commented Feb 28, 2020

#thomaus Type Network is currently working on the Libre Franklin family and making a single weight axis variable font.

This the location of the current alpha data in the fea-conv-ufo branch. The quote issue may be resolved but there is a pre-existing issue with spiking in the /question and /integral. We will make note of this Issue #2062.

@Scott-N
Copy link
Author

Scott-N commented Feb 28, 2020

@pichotta - It looks like your comment above is a link to the repository for Libre Baskerville, not Libre Franklin. There is a "fea-conv-ufo" branch of Libre Franklin here:
https://github.com/TypeNetwork/Libre-Franklin/tree/fea-conv-ufo/fonts
However, it indicates that the italic double quote issue was fixed 3 years ago, before @TypeNetwork forked the project from @impallari:
https://github.com/impallari/Libre-Franklin/tree/master/fonts

It's not clear to me which of the 17 forks from the original by @impallari is used by Google Fonts, but my best guess is that it's the one created by @davelab6, whose profile says "I work at Google on fonts," and whose fork of Libre-Franklin says "This branch is 18 commits behind impallari:master."
https://github.com/davelab6/Libre-Franklin

In other words, this issue appears to have been fixed 3 years ago, but the fix was never committed to the Google Fonts version.

@pichotta
Copy link

@Scott-N
Has the quote issue you mention been fixed here in the TypeNetwork 'master' branch?
https://github.com/TypeNetwork/Libre-Franklin

@Scott-N
Copy link
Author

Scott-N commented Aug 16, 2020

@pichotta - Yes, I downloaded and installed the font files locally, and the italic double quotes are spaced correctly for all weights. But TypeNetwork's fixes have not yet been applied to Google's version:

https://fonts.google.com/specimen/Libre+Franklin?preview.text=%E2%80%9CQuote+me%E2%80%9D&preview.text_type=custom

Anyone know how to get Google to apply the fixes? @davelab6 perhaps? I've been trying for over a year.

@pichotta
Copy link

Hi @Scott-N, My best estimate is that the variable weight axis with this fix will be pushed in the next 4-6weeks.

@emmamarichal
Copy link
Collaborator

solved here: #8134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants