diff --git a/cipher_test.go b/cipher_test.go index b22415c..2b62913 100644 --- a/cipher_test.go +++ b/cipher_test.go @@ -91,8 +91,7 @@ func TestCipherChops(t *testing.T) { l, r := j-s, j Cipher(b[l:r], m, l) if !reflect.DeepEqual(b[l:r], exp[l:r]) { - t.Errorf("unexpected Cipher([%d:%d]) = %x; want %x", l, r, b[l:r], exp[l:r]) - return + t.Fatalf("unexpected Cipher([%d:%d]) = %x; want %x", l, r, b[l:r], exp[l:r]) } } } @@ -103,8 +102,7 @@ func TestCipherChops(t *testing.T) { r := rand.Intn(n-l) + l + 1 Cipher(b[l:r], m, l) if !reflect.DeepEqual(b[l:r], exp[l:r]) { - t.Errorf("unexpected Cipher([%d:%d]):\nact:\t%v\nexp:\t%v\nact:\t%#x\nexp:\t%#x\n\n", l, r, b[l:r], exp[l:r], b[l:r], exp[l:r]) - return + t.Fatalf("unexpected Cipher([%d:%d]):\nact:\t%v\nexp:\t%v\nact:\t%#x\nexp:\t%#x\n\n", l, r, b[l:r], exp[l:r], b[l:r], exp[l:r]) } l = r } diff --git a/dialer_test.go b/dialer_test.go index 8dd258d..d622726 100644 --- a/dialer_test.go +++ b/dialer_test.go @@ -101,8 +101,7 @@ func TestDialerRequest(t *testing.T) { t.Errorf("unexpected request:\nact:\n%s\nexp:\n%s\n", act, exp) } if _, err := http.ReadRequest(bufio.NewReader(&buf)); err != nil { - t.Errorf("read request error: %s", err) - return + t.Fatalf("read request error: %s", err) } }) } diff --git a/server_test.go b/server_test.go index 1f93721..0e44d7c 100644 --- a/server_test.go +++ b/server_test.go @@ -394,21 +394,19 @@ func TestHTTPUpgrader(t *testing.T) { } _, _, hs, err := u.Upgrade(req, res) if test.err != err { - t.Errorf( + t.Fatalf( "expected error to be '%v', got '%v';\non request:\n====\n%s\n====", test.err, err, dumpRequest(req), ) - return } actRespBts := sortHeaders(res.Bytes()) expRespBts := sortHeaders(dumpResponse(test.res)) if !bytes.Equal(actRespBts, expRespBts) { - t.Errorf( + t.Fatalf( "unexpected http response:\n---- act:\n%s\n---- want:\n%s\n==== on request:\n%s\n====", actRespBts, expRespBts, dumpRequest(test.req), ) - return } if act, exp := hs.Protocol, test.hs.Protocol; act != exp { @@ -458,19 +456,16 @@ func TestUpgrader(t *testing.T) { hs, err := u.Upgrade(conn) if test.err != err { - - t.Errorf("expected error to be '%v', got '%v'", test.err, err) - return + t.Fatalf("expected error to be '%v', got '%v'", test.err, err) } actRespBts := sortHeaders(conn.Bytes()) expRespBts := sortHeaders(dumpResponse(test.res)) if !bytes.Equal(actRespBts, expRespBts) { - t.Errorf( + t.Fatalf( "unexpected http response:\n---- act:\n%s\n---- want:\n%s\n==== on request:\n%s\n====", actRespBts, expRespBts, dumpRequest(test.req), ) - return } if act, exp := hs.Protocol, test.hs.Protocol; act != exp { diff --git a/wsutil/cipher_test.go b/wsutil/cipher_test.go index fe16d92..f1460d1 100644 --- a/wsutil/cipher_test.go +++ b/wsutil/cipher_test.go @@ -38,12 +38,10 @@ func TestCipherReader(t *testing.T) { bts, err := ioutil.ReadAll(rd) if err != nil { - t.Errorf("unexpected error: %s", err) - return + t.Fatalf("unexpected error: %s", err) } if !reflect.DeepEqual(bts, test.data) { - t.Errorf("read data is not equal:\n\tact:\t%#v\n\texp:\t%#x\n", bts, test.data) - return + t.Fatalf("read data is not equal:\n\tact:\t%#v\n\texp:\t%#x\n", bts, test.data) } }) } diff --git a/wsutil/helper_test.go b/wsutil/helper_test.go index d3ff10e..901e673 100644 --- a/wsutil/helper_test.go +++ b/wsutil/helper_test.go @@ -26,7 +26,7 @@ func TestReadMessageEOF(t *testing.T) { var buf bytes.Buffer f := ws.NewTextFrame([]byte("this part will be lost")) if err := ws.WriteHeader(&buf, f.Header); err != nil { - panic(err) + t.Fatal(err) } return &buf }, @@ -44,7 +44,7 @@ func TestReadMessageEOF(t *testing.T) { } for _, f := range fs { if err := ws.WriteFrame(&buf, f); err != nil { - panic(err) + t.Fatal(err) } } return &buf diff --git a/wsutil/reader_test.go b/wsutil/reader_test.go index b0676c1..4204bf3 100644 --- a/wsutil/reader_test.go +++ b/wsutil/reader_test.go @@ -105,7 +105,7 @@ func TestReaderNextFrameAndReadEOF(t *testing.T) { var buf bytes.Buffer f := ws.NewTextFrame([]byte("this part will be lost")) if err := ws.WriteHeader(&buf, f.Header); err != nil { - panic(err) + t.Fatal(err) } return &buf }, @@ -117,7 +117,7 @@ func TestReaderNextFrameAndReadEOF(t *testing.T) { var buf bytes.Buffer f := ws.NewTextFrame([]byte("foobar")) if err := ws.WriteHeader(&buf, f.Header); err != nil { - panic(err) + t.Fatal(err) } buf.WriteString("foo") return &buf @@ -130,7 +130,7 @@ func TestReaderNextFrameAndReadEOF(t *testing.T) { var buf bytes.Buffer f := ws.NewFrame(ws.OpText, false, []byte("payload")) if err := ws.WriteFrame(&buf, f); err != nil { - panic(err) + t.Fatal(err) } return &buf }, @@ -197,7 +197,7 @@ func TestMaxFrameSize(t *testing.T) { func TestReaderUTF8(t *testing.T) { yo := []byte("Ё") if !utf8.ValidString(string(yo)) { - panic("bad fixture") + t.Fatal("bad fixture") } var buf bytes.Buffer @@ -324,8 +324,7 @@ func TestNextReader(t *testing.T) { bts, err = ioutil.ReadAll(reader) } if err != test.err { - t.Errorf("unexpected error; got %v; want %v", err, test.err) - return + t.Fatalf("unexpected error; got %v; want %v", err, test.err) } if test.err == nil && !bytes.Equal(bts, test.exp) { t.Errorf( diff --git a/wsutil/utf8_test.go b/wsutil/utf8_test.go index e24204e..09caa40 100644 --- a/wsutil/utf8_test.go +++ b/wsutil/utf8_test.go @@ -151,20 +151,16 @@ func TestUTF8Reader(t *testing.T) { } } if test.err && err == nil { - t.Errorf("want error; got nil") - return + t.Fatalf("want error; got nil") } if !test.err && err != nil { - t.Errorf("unexpected error: %s", err) - return + t.Fatalf("unexpected error: %s", err) } if test.err && err == ErrInvalidUTF8 && i != test.at { - t.Errorf("received error at %d; want at %d", i, test.at) - return + t.Fatalf("received error at %d; want at %d", i, test.at) } if act, exp := r.Valid(), test.valid; act != exp { - t.Errorf("Valid() = %v; want %v", act, exp) - return + t.Fatalf("Valid() = %v; want %v", act, exp) } if !test.err && !bytes.Equal(bts, data) { t.Errorf("bytes are not equal") diff --git a/wsutil/writer_test.go b/wsutil/writer_test.go index d069d09..eec99ab 100644 --- a/wsutil/writer_test.go +++ b/wsutil/writer_test.go @@ -87,8 +87,7 @@ func TestControlWriter(t *testing.T) { return } if !test.err && err != nil { - t.Errorf("unexpected error: %v", err) - return + t.Fatalf("unexpected error: %v", err) } act, err := ws.ReadFrame(&buf) @@ -338,12 +337,12 @@ func TestWriter(t *testing.T) { if bts := buf.Bytes(); !bytes.Equal(test.expBts, bts) { t.Errorf( "wrote bytes:\nact:\t%#x\nexp:\t%#x\nacth:\t%s\nexph:\t%s\n", bts, test.expBts, - pretty(frames(bts)...), pretty(frames(test.expBts)...), + pretty(frames(t, bts)...), pretty(frames(t, test.expBts)...), ) } } if test.expFrm != nil { - act := omitMasks(frames(buf.Bytes())) + act := omitMasks(frames(t, buf.Bytes())) exp := omitMasks(test.expFrm) if !reflect.DeepEqual(act, exp) { @@ -529,7 +528,7 @@ func TestWriterReadFrom(t *testing.T) { if n != test.n { t.Errorf("ReadFrom() read out %d; want %d", n, test.n) } - if frames := frames(dst.Bytes()); !reflect.DeepEqual(frames, test.exp) { + if frames := frames(t, dst.Bytes()); !reflect.DeepEqual(frames, test.exp) { t.Errorf("ReadFrom() read frames:\n\tact:\t%s\n\texp:\t%s\n", pretty(frames...), pretty(test.exp...)) } }) @@ -603,7 +602,8 @@ func (w *writeCounter) Write(p []byte) (int, error) { return len(p), nil } -func frames(p []byte) (ret []ws.Frame) { +func frames(tb testing.TB, p []byte) (ret []ws.Frame) { + tb.Helper() r := bytes.NewReader(p) for stop := false; !stop; { f, err := ws.ReadFrame(r) @@ -611,7 +611,7 @@ func frames(p []byte) (ret []ws.Frame) { if err == io.EOF { break } - panic(err) + tb.Fatal(err) } ret = append(ret, f) }