Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expander: non deterministic expansion on some circular ref patterns #93

Open
fredbi opened this issue Jul 4, 2019 · 2 comments · May be fixed by #121
Open

Expander: non deterministic expansion on some circular ref patterns #93

fredbi opened this issue Jul 4, 2019 · 2 comments · May be fixed by #121

Comments

@fredbi
Copy link
Member

fredbi commented Jul 4, 2019

Let's make things official about this limitation, mentioned in the discussion following #75 (credits @elakito):

  • when $ref do form several cycles (i.e. out of the root document)
  • when some of those cycles have an intersection

then the expander chose some random expansion path from the common cycle

This behavior is illustrated by this fixture (not run by tests).

@magodo
Copy link
Contributor

magodo commented Aug 27, 2020

@fredbi Is there any progress on this issue?

@fredbi
Copy link
Member Author

fredbi commented Aug 27, 2020

@magodo no. I've worked a bit on it last year then gave up since I found it very difficult to solve.

@magodo magodo linked a pull request May 30, 2023 that will close this issue
@fredbi fredbi added the expand label Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants