You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in basic_fun.cpp we have useless in most *arr (eg LONARR) portions of code because test of the dim are now done in arr()
e.g. :
arr(e, dim);
if (dim[0] == 0)
throw GDLException("Array dimensions must be greater than 0");
but in arr()
...
if (ret < 0) throw GDLException(BadDims);
...
if (newDim < 1) throw GDLException(BadDims);
Would someone give a look and canfirm we can removed the useless code ?
/nozero is present in all the *arr functions below but STRARR
in fact : no /nozero in STRARR in IDL, and /nozero does exist in IDL for OBJARR & PRTARR but are not documented !
GDL> help,/lib, name='*arr'
Library procedures (0):
Library functions (14):
res=BYTARR([8 Args],NOZERO)
res=COMPLEXARR([8 Args],NOZERO)
res=DBLARR([8 Args],NOZERO)
res=DCOMPLEXARR([8 Args],NOZERO)
res=FLTARR([8 Args],NOZERO)
res=INTARR([8 Args],NOZERO)
res=LON64ARR([8 Args],NOZERO)
res=LONARR([8 Args],NOZERO)
res=OBJARR([8 Args]) <<---- missing in GDL
res=PTRARR([8 Args],ALLOCATE_HEAP) <<---- missing in GDL
res=STRARR([8 Args],NOZERO) <<---- to be removed in GDL
res=UINTARR([8 Args],NOZERO)
res=ULON64ARR([8 Args],NOZERO)
res=ULONARR([8 Args],NOZERO)
% At $MAIN$
The text was updated successfully, but these errors were encountered:
indeed arr() checks dims are not zero. So the supplementary test is not useful. Same as some checks on number of params when e->NParam(n) has been called before.
Not an issue, though.
2 points :
basic_fun.cpp
we have useless in most *arr (eg LONARR) portions of code because test of the dim are now done in arr()e.g. :
Would someone give a look and canfirm we can removed the useless code ?
in fact : no /nozero in STRARR in IDL, and /nozero does exist in IDL for OBJARR & PRTARR but are not documented !
The text was updated successfully, but these errors were encountered: