Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS S3 bucket as a upload storage #322

Open
1 task done
OleksandrKucherenko opened this issue Oct 5, 2024 · 1 comment
Open
1 task done

Support AWS S3 bucket as a upload storage #322

OleksandrKucherenko opened this issue Oct 5, 2024 · 1 comment
Assignees
Labels
type: feature-request New feature or request

Comments

@OleksandrKucherenko
Copy link

🔖 Feature description

R2 provided API that is fully compatible with the Amazon AWS S3.

Why not support AWS S3, then? It is a "low-hanging fruit".

🎤 Why is this feature needed ?

The S3 bucket has a lot of excellent options that developers love. Many developers already have their own AWS accounts, and for self-hosting solutions, it can be a valuable option.

✌️ How do you aim to achieve this?

  1. update .env.* file configuration, and add additional optional variables that allow configuring of the hoster/provider for the S3 client
  2. A small terraform script that allows the creation of a s3 bucket with a lifetime policy (store image file for 24h)

🔄️ Additional Information

minio also provides S3 API-compatible interface, and it can be run in a docker container. So it can be used for local testing.

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

Yes I am willing to submit a PR!

@OleksandrKucherenko OleksandrKucherenko added the type: feature-request New feature or request label Oct 5, 2024
@nevo-david
Copy link
Contributor

@OleksandrKucherenko, I have just merged @SanadKhan's commit on more generic uploading.
Feel free to head to libraries/nestjs-libraries/src/upload/upload.factory.ts
And implement S3 :)
Assigning it to you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants