Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoExt.form.toFilter inserts wildcards for empty string field values #73

Open
justb4 opened this issue Jun 18, 2013 · 0 comments
Open

Comments

@justb4
Copy link
Contributor

justb4 commented Jun 18, 2013

This issue was found in Heron (https://code.google.com/p/geoext-viewer/issues/detail?id=235) but applies to the function GeoExt.form.toFilter in

https://github.com/geoext/geoext/blob/master/lib/GeoExt/widgets/form.js

Problem is that in some forms with OR-ed fields where the user leaves fields empty and when wildcarding is enabled, the toFilter function will still add a wildcard to an empty string. In the worst case one may get the entire content of a DB. FIx is to skip filter encoding for fields with value is empty string and when wildcarding is one. We fixed this in Heron by overriding (also fixing other stuff), but may supply the fix as a pull as well. See fixed version here (line 267):

https://code.google.com/p/geoext-viewer/source/browse/trunk/heron/lib/override-geoext.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant