Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC runtime libraries are installed on Windows #188

Open
cottsay opened this issue Sep 18, 2021 · 2 comments
Open

MSVC runtime libraries are installed on Windows #188

cottsay opened this issue Sep 18, 2021 · 2 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed Windows Windows support

Comments

@cottsay
Copy link
Contributor

cottsay commented Sep 18, 2021

Environment

  • OS Version: Windows 10
  • Source or binary build?
    44a699c
    ...
    -- Install configuration: "Release"
    -- Installing: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin/msvcp140.dll
    -- Installing: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin/msvcp140_1.dll
    -- Installing: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin/msvcp140_2.dll
    -- Installing: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin/msvcp140_atomic_wait.dll
    -- Installing: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin/msvcp140_codecvt_ids.dll
    -- Installing: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin/vcruntime140_1.dll
    -- Installing: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin/vcruntime140.dll
    -- Installing: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin/concrt140.dll
    -- Up-to-date: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin
    ...

Description

  • Expected behavior: No binary files are installed by this package
  • Actual behavior: MSVC runtime libraries are installed by this package

Steps to reproduce

  1. Build on Windows
  2. Install on Windows
  3. Observe the list of operations performed during install
@cottsay cottsay added the bug Something isn't working label Sep 18, 2021
@traversaro
Copy link
Contributor

To avoid that, in conda-forge recipes we pass the CMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP option, see https://github.com/conda-forge/libignition-math4-feedstock/blob/31df1d0d6d4f6d372061a8e4ce45d5923468a5f4/recipe/bld.bat#L8 .

@traversaro
Copy link
Contributor

@chapulina chapulina added help wanted Extra attention is needed Windows Windows support labels Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed Windows Windows support
Projects
None yet
Development

No branches or pull requests

4 participants