Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip auth server if player's logged #1271

Open
1 task done
nicuzzodiddio opened this issue Dec 1, 2024 · 6 comments
Open
1 task done

Skip auth server if player's logged #1271

nicuzzodiddio opened this issue Dec 1, 2024 · 6 comments
Labels
enhancement New feature or change request

Comments

@nicuzzodiddio
Copy link

Is your feature request related to a problem? Please describe.

At the moment, if you use fastlogin + authme reloaded, in authme's config you can have the server to send the player into another server after login, but you will still be logged into auth and after 1-2 seconds sent to the lobby server, which is decent, but would be even better if when you login, the proxy will check if you're already logged (either via fastlogin or authme) and skip the auth server login, and just send you to the lobby server.

Describe the solution you'd like

At the moment, if you use fastlogin + authme reloaded, in authme's config you can have the server to send the player into another server after login, but you will still be logged into auth and after 1-2 seconds sent to the lobby server, which is decent, but would be even better if when you login, the proxy will check if you're already logged (either via fastlogin or authme) and skip the auth server login, and just send you to the lobby server.

Describe alternatives you've considered

There's no plugin that does this at the moment, so why not creating one, even an addon

Platform

All / Shared

Relevance

  • I checked for existing tickets -
    If there are, please vote them with a thumbs reaction and not create new ones
@nicuzzodiddio nicuzzodiddio added the enhancement New feature or change request label Dec 1, 2024
@nicuzzodiddio nicuzzodiddio reopened this Dec 2, 2024
@games647
Copy link
Owner

games647 commented Dec 2, 2024

In theory this is possible, but not from FastLogin's side. This plugin handles and provides the onlinemode information, but how and when the auth plugin reads this data is up to the auth plugin.

The current default implementation for AuthMe is very basic. It would require an extra plugin on the proxy side to handle this. The issue is that AuthMe is primary a Spigot plugin. In order to get the result of force login request it requires a full player connection to the Spigot server. The auth plugin could reject the request if there is an error or unregistered user. The question is how should FastLogin handle or request to it.

@nicuzzodiddio
Copy link
Author

How do other plugins handle this? Jpremium and librelogim (where last one only goes into proxy server) have this.
The obly thing i could think of is making an addon and handling this via authme api, where if player is authenticated, it will send a plugin message to a proxy plugin where if received, it will send the player onto another server, but that process kinda slow and wouldn't work the way I want it.

@games647
Copy link
Owner

games647 commented Dec 2, 2024

Both plugins are all in one. So all logic is internal and known. There is no external dependency.

I mean what also could work is that if the player is premium and not new (-> existing player), we choose the lobby server first and only teleport to the auth plugin if the force login fails. That fit the vast majority of cases, because the failure would only be an exception to the normal workflow and very rare (like an unregistered account by admin or purge).

@nicuzzodiddio
Copy link
Author

Both plugins are all in one. So all logic is internal and known. There is no external dependency.

I mean what also could work is that if the player is premium and not new (-> existing player), we choose the lobby server first and only teleport to the auth plugin if the force login fails. That fit the vast majority of cases, because the failure would only be an exception to the normal workflow and very rare (like an unregistered account by admin or purge).

Ye that sounds like a better solution, would you consider adding that into the plugin? And theres the thing with cracked players too, as they should skip the auth if theyre logged through authme session

@nicuzzodiddio
Copy link
Author

Bump

@games647
Copy link
Owner

games647 commented Dec 4, 2024

Bump

I'm sorry, but this is free project that I'm doing in my free time. It's not my top priority.

Ye that sounds like a better solution, would you consider adding that into the plugin?

It would fit better into a different plugin. FastLogin should only provide the base for other plugins to be used.

And theres the thing with cracked players too, as they should skip the auth if theyre logged through authme session

However, the suggested solution will not change this, because this information is not available during the login phase only when the player is completely logged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or change request
Projects
None yet
Development

No branches or pull requests

2 participants