Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JEMALLOC_VERSION to change version without code change #12

Open
gaffneyc opened this issue May 7, 2019 · 0 comments
Open

Allow JEMALLOC_VERSION to change version without code change #12

gaffneyc opened this issue May 7, 2019 · 0 comments

Comments

@gaffneyc
Copy link
Owner

gaffneyc commented May 7, 2019

It has come up a couple times that people are surprised that just changing JEMALLOC_VERSION isn't enough. Today, changing the environment variable also requires a code push because it is copied in during the build phase. This helps avoid applications issues if the version of jemalloc changes or isn't available during a dyno reboot. It also means we're much better citizens to GitHub since we make one request per build instead of one request per restart per dyno.

To make this work we would need to do a version check during the boot process. Heroku offers some storage for buildpacks where we could stash downloaded versions instead of always requesting them from GitHub, or only need to request them once per version.

@gaffneyc gaffneyc changed the title Allow JEMALLOC_VERISON to change version without code change Allow JEMALLOC_VERSION to change version without code change May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant