Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider creating an ember-modifier class #109

Open
Panman82 opened this issue Dec 10, 2021 · 1 comment
Open

Consider creating an ember-modifier class #109

Panman82 opened this issue Dec 10, 2021 · 1 comment

Comments

@Panman82
Copy link
Contributor

The <FroalaEditor /> component largely depends on interaction with the attached element to initialize the Froala Editor. Technically ember now allows this access by using a modifier. Most of the <FroalaEditor /> code could be moved to a modifier class definition. However, there are some downsides that the component version guards against (mainly ensuring @content is passed in and not used as block content <FroalaEditor>{{this.content}}</FroalaEditor>). Currently this addon uses ember-render-modifiers to gain access to the element. At minimum, I would say both (component and modifier) would be provided by the addon if we do move to a modifier. An alternate and more custom solution is to create a custom modifier manager too, to avoid a dependency on ember-modifier.

@Panman82
Copy link
Contributor Author

One question to be answered is with extensibility. If the consumer extends the modifier, will the built-in component use the extended modifier? And is that ideal?

Panman82 added a commit that referenced this issue Oct 1, 2024
Runloop usage is in tests, not components. Render modifiers will be done whenever froala-editor v5 comes out, or ember-addon v2 format is done. Existing issue for this task: #109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant