Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolbarSticky not working #14

Open
reganlawton opened this issue Jun 13, 2019 · 11 comments
Open

toolbarSticky not working #14

reganlawton opened this issue Jun 13, 2019 · 11 comments

Comments

@reganlawton
Copy link
Contributor

It seems that the sticky toolbar doesn't work. This is quite annoying for large content snippets. Do we have a fix of work around for it?

@bertoost
Copy link
Contributor

I understand. I have to figure that out. Hopefully I can get to it tomorrow. Hang on!

@reganlawton
Copy link
Contributor Author

Thanks for looking into this one. I’ll let the client know this is being looked into. Again thanks for your support.

@bertoost
Copy link
Contributor

Hm I can't figure it out either.. Seems not to work at all, even with a scrollableContainer set to it's parent container element with ID #content.
I will contact Froala team about it.

@reganlawton
Copy link
Contributor Author

Hmm yeah it’s a weird one 🤷‍♂️

@dejanmartinovic
Copy link

Editor itself cannot be set as the scrolalbleContainer.
You could put there a parent which is scrollable.
Please find a simple example here: https://jsfiddle.net/dejan_m/Lzq1b3jn/4/
Best, Dejan

@bertoost
Copy link
Contributor

Thanks @dejanmartinovic ! I understand. But I tried with it's parent element as scrollable container but that didn't work either

@reganlawton
Copy link
Contributor Author

I’m sick today but I might give this a looksie tomorrow if I’m feeling better. I did see that it does initialises the sticky toolbar just doesn’t trigger it might need some additional code.

Also IDs won’t work as my case we use it inside a Matrix field and which need to support multiple text blocks. This also has another issue where it could have multiple of toolbars layered But this said if the toolbar stickiness is only till the bottom of the container this could be fine.

@bertoost
Copy link
Contributor

@reganlawton I am testing it with the #content ID of Craft. It's the container for all fields. But that's not working either for a normal field (not matrix).

Ps. Hopefully you get better soon

@reganlawton
Copy link
Contributor Author

Yeah no have slept through the worst of it. I’ll have a look at it tomorrow I might go into the office early and see what I can do.

@bertoost
Copy link
Contributor

bertoost commented Jul 2, 2019

FYI; I can't get it to work. I guess it has something to do with how Craft's CP is working (css's flex-box) regarding how Froala's editor is checking the scrolling position. I can imagine this is annoying, but I am getting a little bit out of options.

@reganlawton
Copy link
Contributor Author

@bertoost I haven't gotten a chance to troubleshoot with the new information, been smashed with projects lately. Let's hope I get more luck I'm on the project this is affecting later this week and I'll assign some out of office hours towards it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants