Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journalist fetching keys are signed and verified using the newsroom key instead of their own signing key #25

Closed
lsd-cat opened this issue Oct 30, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@lsd-cat
Copy link
Member

lsd-cat commented Oct 30, 2023

The bug is repeated all across the code and that is why there are no signatures mismatch. Caught it when refactoring for the libsodium-only branch. If we merge that there is no need to do anything as it is fixed there. If we end up not merging, then we should track it in this issue and eventually fix it.

(non exhaustive list):

@lsd-cat lsd-cat added the bug Something isn't working label Dec 22, 2023
@lsd-cat
Copy link
Member Author

lsd-cat commented Mar 27, 2024

Closing as we merged #24 that includes a fix.

@lsd-cat lsd-cat closed this as completed Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant