Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Release files are not detected by our checks #11

Open
apyrgio opened this issue Dec 11, 2023 · 0 comments
Open

Missing Release files are not detected by our checks #11

apyrgio opened this issue Dec 11, 2023 · 0 comments

Comments

@apyrgio
Copy link
Contributor

apyrgio commented Dec 11, 2023

While releasing Dangerzone 0.5.1, we realized that the Ubuntu Focal repo does not have any Release files (see freedomofpress/dangerzone#653)

The reason behind this seems to be that ./tools/publish is not idempotent, if one terminates it abruptly (Ctrl-C) and retries. Worst, the validations reprepro performs (invoked by the ./tools/publish script) on the repo are not enough. The following commands complete successfully in our (corrupted in b5730cf) repo:

reprepro --basedir ./repo --outdir ./repo/public check
reprepro --basedir ./repo --outdir ./repo/public checkpool

(The reprepro version when testing the above commands is 5.4.2)

The deleteunreferenced / clearvanished commands are not picking up on the issue as well.

Until we have a way to be sure that the repo is not corrupted, the best way forward is to delete the following directories, whenever we "publish" packages:

./repo/db/
./repo/public/dists/
./repo/public/pool/

This is something we've been manually doing after all on every commit, so we will basically make it part of the script.
@apyrgio apyrgio changed the title Verify the repo is not in a corrupted state Missing RELEASE files are not detected by our checks Dec 11, 2023
apyrgio added a commit to apyrgio/apt-tools-prod that referenced this issue Dec 11, 2023
@apyrgio
Add missing Ubuntu Focal Release files
462dfb1 
Rerun the ./tools/publish script, after removing the ./repo/db
directory, in order to create the missing Release files for Ubuntu
Focal.

By doing so, we also update the Release files for the rest of the
distributions as well.

Refs freedomofpress#11
This was referenced Dec 11, 2023
Merged
Closed
apyrgio added a commit to apyrgio/apt-tools-prod that referenced this issue Dec 12, 2023
@apyrgio
Clean up repo before publishing artifacts
ad60838 
Make sure to clean up the repo, before publishing artifacts. Starting
from scratch is necessary if we want to avoid some edge cases that can
lead to a corrupted APT repo.

Refs freedomofpress#11
apyrgio added a commit to apyrgio/apt-tools-prod that referenced this issue Dec 12, 2023
@apyrgio
ci: Validate that all distros have Release files
e7b863e 
Fixes freedomofpress#11
apyrgio added a commit to apyrgio/apt-tools-prod that referenced this issue Dec 12, 2023
@apyrgio
Clean up repo before publishing artifacts
2ef99e1 
Make sure to clean up the repo, before publishing artifacts. Starting
from scratch is necessary if we want to avoid some edge cases that can
lead to a corrupted APT repo.

Refs freedomofpress#11
apyrgio added a commit to apyrgio/apt-tools-prod that referenced this issue Dec 12, 2023
@apyrgio
ci: Validate that all distros have Release files
f739d3b 
Fixes freedomofpress#11
@apyrgio apyrgio mentioned this issue Dec 12, 2023
Closed
@apyrgio apyrgio changed the title Missing RELEASE files are not detected by our checks Missing Release files are not detected by our checks Dec 12, 2023
apyrgio added a commit to apyrgio/apt-tools-prod that referenced this issue Feb 22, 2024
@apyrgio
Clean up repo before publishing artifacts
dedc536 
Make sure to clean up the repo, before publishing artifacts. Starting
from scratch is necessary if we want to avoid some edge cases that can
lead to a corrupted APT repo.

Refs freedomofpress#11
apyrgio added a commit to apyrgio/apt-tools-prod that referenced this issue Feb 22, 2024
@apyrgio
ci: Validate that all distros have Release files
b2d70d1 
Fixes freedomofpress#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure that distros have Release files apyrgio/apt-tools-prod
1 participant
@apyrgio