-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 8 Storage Places as functionality to the app #638
Comments
@mariobehling we can create beautiful animations with this. Small 8 frame animations |
I've looked at the code a bit and right now it seems to only support setting all the messages at once. https://github.com/fossasia/badge-magic-android/blob/0148c450a17db91b6792bfcc32fac97787f672a2/android/src/main/java/org/fossasia/badgemagic/util/SendingUtils.kt#L58-L60 takes a single message, but this should be changed to accepting a The complexity now comes from the UI: how to make a good UI for setting up to 8 different values... I'm willing to adopt this feature request and try to implement it myself, but it will take me some time to figure everything out. |
@TheLastProject you're on the right track, let me know if you need anything |
Hey, can I take this issue up? |
I am not a maintainer (they sadly don't seem very active), but I just want to say you're free to use as much or as little code from #644 as you see fit. I will not be offended if my word-in-progress code gets thrown away for a better implementation :) |
Yes, feel free to. Also @TheLastProject had an amazing implementation. I forgot to review your pr xD Sorry about that. It only needed a couple of additions, you can continue where he left off. I will be able to review it this weekend. |
Any movement on this? |
The proprietary app of the LED Badges has a storage functionality for 8 types. Please add this functionality to the app.
These 8 Storage places mean the the badge LED art is stored directly on the badge itself.
Compare: https://play.google.com/store/apps/details?id=com.ls.shaheen.ledcard
The text was updated successfully, but these errors were encountered: