Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Popup clears the selection mark when selecting text with errors #14

Open
fmichaut-diff opened this issue Aug 15, 2023 · 0 comments
Open

Comments

@fmichaut-diff
Copy link

When selecting text in emacs by holding the SHIFT key and moving my cursor around with the ARROW keys, if I step on a word highlighted by flycheck, it will open the popup with the error message, clearing my selection at the same time.

This is particularly infuriating when trying to fix errors reported by flycheck when refactoring code, since selecting the offending piece of code, usually results in stepping on a flycheck error which clears the whole thing.

Steps to reproduce the behavior:

  • Open some file with flycheck errors
  • Position your cursor before an error
  • Hold SHIFT and move your cursor over the error, trying to select the area from before the error, to after the error.
  • Observe the selection being cut in the middle when the cursor was on the flycheck error.

I would expect that, when selecting code, the popup should not open, or if it must, it should not clear the selection.

hlissner added a commit to doomemacs/doomemacs that referenced this issue Apr 7, 2024
Moving the cursor over a flycheck-highlighted error will display the
error message in a popup. Displaying that popup could clear the active
selection (#7242), which is disruptive. This only affected non-Evil
users and users not using the module's +childframe flag, but should no
longer affect anyone after this commit.

Fix: #7242
Ref: flycheck/flycheck-popup-tip#14
peterhoeg pushed a commit to peterhoeg/doomemacs that referenced this issue Apr 8, 2024
Moving the cursor over a flycheck-highlighted error will display the
error message in a popup. Displaying that popup could clear the active
selection (doomemacs#7242), which is disruptive. This only affected non-Evil
users and users not using the module's +childframe flag, but should no
longer affect anyone after this commit.

Fix: doomemacs#7242
Ref: flycheck/flycheck-popup-tip#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant