Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "raise vs E2MM#Raise" benchmark from repository #95

Open
radarek opened this issue Jan 24, 2016 · 3 comments
Open

Remove "raise vs E2MM#Raise" benchmark from repository #95

radarek opened this issue Jan 24, 2016 · 3 comments

Comments

@radarek
Copy link

radarek commented Jan 24, 2016

It's nice that someone found that this library is so slow but I think most Ruby devs don't know that e2mmap even exists (actually I learned about this library from this repo). IMHO it would be better to not tell other developers that it exists. I even grepped all gems from ~/.rbenv/ (more that 2000 gems) and only rdoc & yard gems use it (actually they include file ruby_lex.rb). All other benchmarks are more or less used in a real code but this one is completely impractical.

@nateberkopec
Copy link
Collaborator

👍 I've never heard of it, but I wasn't around when it was merged so I dunno the reasoning.

@kbrock
Copy link
Contributor

kbrock commented Apr 27, 2018

👍 does it make sense to just convert this into a PR - seems easier for the maintainers to just click merge.

also noticed that e2mmap has no readme and last changed in 2013

@etagwerker
Copy link
Member

At the moment that particular benchmark is failing (#196) with Ruby 3.0.2, so I went ahead and submitted a PR to remove it from this repo: #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants