Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding content to NumericFeatureFrame needs re-normalisation #109

Open
fako opened this issue Aug 18, 2018 · 0 comments
Open

Adding content to NumericFeatureFrame needs re-normalisation #109

fako opened this issue Aug 18, 2018 · 0 comments
Labels

Comments

@fako
Copy link
Owner

fako commented Aug 18, 2018

When you add new content to a NumericFeatureFrame on top of existing content, then the min max normalisation needs to be recalculated for all content. Currently the existing content and new content will have their own scale.

The TestNumericFeaturesFrame.test_adding_content_mixed test demonstrates the wrong behaviour.

rank_by_params should also be called score_by_params

@fako fako added the bug label Aug 18, 2018
@fako fako added this to the wiki-feed-first-feed milestone Aug 18, 2018
@fako fako removed this from the data-growth-package milestone Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant