From 33b87bd3cf0be019ba2fea689263e3b561cc9a73 Mon Sep 17 00:00:00 2001 From: alexeib Date: Wed, 28 Oct 2020 18:27:53 -0700 Subject: [PATCH] fix architecture params (#1382) Summary: fixes architectures not getting applied to migrated models Pull Request resolved: https://github.com/fairinternal/fairseq-py/pull/1382 Reviewed By: myleott Differential Revision: D24603110 Pulled By: alexeib fbshipit-source-id: 18f44d3736853282466feed5e8896db95338b097 --- fairseq/models/fairseq_model.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fairseq/models/fairseq_model.py b/fairseq/models/fairseq_model.py index 7ca1c54308..e6a0512a58 100644 --- a/fairseq/models/fairseq_model.py +++ b/fairseq/models/fairseq_model.py @@ -35,7 +35,8 @@ def add_args(cls, parser): """Add model-specific arguments to the parser.""" dc = getattr(cls, "__dataclass", None) if dc is not None: - gen_parser_from_dataclass(parser, dc()) + # do not set defaults so that settings defaults from various architectures still works + gen_parser_from_dataclass(parser, dc(), delete_default=True) @classmethod def build_model(cls, args, task):