Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which OpenClip should be used #13

Open
shkarupa-alex opened this issue Oct 19, 2023 · 1 comment
Open

Which OpenClip should be used #13

shkarupa-alex opened this issue Oct 19, 2023 · 1 comment

Comments

@shkarupa-alex
Copy link

It is not clear from readme:

  1. Did you use your copy of OpenClip (from src) or OpenClip from pypi?
  2. Why did you decided to use QuickGelu if it is slower and much memory-hungry?
@howardhsu
Copy link
Contributor

1, good question, we use our copy of OpenCLIP and customize the setup to OpenAI CLIP (that was never done before).
2, we aim for controlled experiments over OpenAI CLIP so all gains are from data ONLY for fair comparison on data and all data algorithms in future.
All existing non OpenAI works are not changing data alone: big batch size, model, lr. These are CLIP "system" that can always combine w/ latest NN tech or hardware; these are not very related to CLIP itself (eg changing activation function are common to every transformer).
BTW, we notice slightly better acc. perf. on quickgelu over gelu in 2nd half of training (not initially); so we suspect the benefits of gelu is not fully verified but very ad-hoc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants