Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion of a new observable #12934

Open
MalikHou opened this issue Aug 14, 2024 · 0 comments
Open

Discussion of a new observable #12934

MalikHou opened this issue Aug 14, 2024 · 0 comments

Comments

@MalikHou
Copy link

Hi All
There is a trace sampling requirement in our business, the purpose is to understand what a query request has experienced throughout its life cycle. The existing trace solution is obviously not very satisfactory. My initial idea is as follows:

  1. Add trace strcut, which includes some data:
  • bool hit_mem_table;
  • bool hit_row_cache;
  • bool hit_block_cache;
  • bool hit_sys_disk;
  • uint64_t read_disk_us;
    ...
  1. Overload the new Get method and add the parameter trace struct to the function signature;
  2. If the trace object exists, write the statistical information to the trace in the key path of the code.

Note that the generation of trace has a certain sampling rate, and not every request calls this method.

I haven't received a timely reply in the mail group & hope to hear from everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant