Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly a DexMethod::set_deobfuscated_name issue? #786

Open
fengruisd opened this issue May 18, 2023 · 2 comments
Open

Possibly a DexMethod::set_deobfuscated_name issue? #786

fengruisd opened this issue May 18, 2023 · 2 comments

Comments

@fengruisd
Copy link

the input parameter name is normally generated by show(method), which means it is the full name of the method. on the other hand, the return value of method->get_name(), and the input paramter of g_redex->erase_method and g_redex->get_method is the simple name of a method.

So, would the place marked in the illustration below be a mistake?

image

@thezhangwei
Copy link
Contributor

Yeah passing in the full name seems to be off. I think you are right on that.
However, kInsertDeobfuscatedNameLinks is defaulted to be false. So the deobfuscated name lookup is not being used. We found it to be problematic. Hope this helps. :)

@agampe
Copy link
Contributor

agampe commented Jul 13, 2023

On the other hand, thinking about it, though, the deobfuscated name may be with a different class name altogether? Just using the deobfuscated name wouldn't generally be enough to find the right method? Not sure how that ever worked correctly together at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants