Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no limitation for "%s" while calling fscanf() #126

Open
QiAnXinCodeSafe opened this issue Jul 28, 2020 · 0 comments
Open

no limitation for "%s" while calling fscanf() #126

QiAnXinCodeSafe opened this issue Jul 28, 2020 · 0 comments

Comments

@QiAnXinCodeSafe
Copy link

openbmc/meta-facebook/meta-elbert/recipes-utils/wedge-eeprom/files/utils/elbert_weutil.c

Line 34 in e91ee64

fscanf(fp, "%s", buffer);

facebook-github-bot pushed a commit that referenced this issue Dec 21, 2020
@joancaneus @facebook-github-bot
ELBERT: refactors EEPROM code to library and fixes PIM8DDM part numbe…
c15a765 
…r in weutil (#126)

Summary:
This makes two changes to the Elbert wedge-eeprom code:
1. Refactors the elbert-eeprom code into its own library so that it can be used by the Elbert platform-lib code.
2. Fixes an issue where garbage characters are printed at the end of the PIM8DDM part number in weutil.

## Testing

EEPROM CIT tests pass.

Verified that the PIM8DDM part number is now correct:
```
root@bmc-oob:~# pim_types.sh
PIM 2: PIM16Q
PIM 3: PIM16Q
PIM 4: PIM16Q
PIM 5: PIM16Q
PIM 6: PIM8DDM
PIM 7: PIM16Q
PIM 8: PIM16Q
PIM 9: PIM16Q

root@bmc-oob:~# weutil pim6
Wedge EEPROM pim6:
Version: 0
Product Name: ELBERT
Product Part Number: 7388-8D
System Assembly Part Number: ASY055040104
Facebook PCBA Part Number:
Facebook PCB Part Number:
ODM PCBA Part Number: PCA015220106
ODM PCBA Serial Number:
Product Production State: 0
Product Version: 10
Product Sub-Version: 1
Product Serial Number: JAS20370017
Product Asset Tag:
System Manufacturer:
System Manufacturing Date: 2020010100
PCB Manufacturer:
Assembled At:
Local MAC: D4:AF:F7:2F:32:A6
Extended MAC Base: D4:AF:F7:2F:98:D0
Extended MAC Address Size: 139
Location on Fabric:
CRC8: 0x0
```

Pull Request resolved: facebookexternal/openbmc.arista#126

Reviewed By: benwei13

fbshipit-source-id: 2dfb73f46c
facebook-github-bot pushed a commit that referenced this issue Apr 5, 2023
@tao-ren @facebook-github-bot
common: linux-6.1: add shutdown method for ast2500-spi
1816d3b 
Summary:
Override patch file #126 with #151 because the new patch (copied from
linux-aspeed-6.0) can be safely applied to all the openbmc platforms.

Test Plan:
1) "bitbake cmm-image" succeeded.
2) rebooted cmm image (running linux 6.1) for a few times: no issue
   found.

Reviewed By: williamspatrick

Differential Revision: D44718621

fbshipit-source-id: eb57a465d9fa8b9cfab86abc35564470b9f01552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@QiAnXinCodeSafe