The return value of 'sscanf()' should be checked #120

QiAnXinCodeSafe · 2020-05-27T09:39:15Z

openbmc/common/recipes-core/rackmon/rackmon/modbus.c

Line 53 in a5afaf5

sscanf(buf + i, "%2hhx", buf + (i / 2));

Summary: ELBERT: bios_util.sh: Improve stability - Add retry_command method to board-utils.sh. This might later be expanded to other utilities. - Split bios program into write and verify stages, where the verify stage is retried to remove false negatives Testing: ``` With up to 5 retries, 340 program cycles of alternating images succeeded. The false positive failure rate is about 15% for the full 16MB image. The reason for these false readings is being investigated/ With 5 retries, the theoretical failure rate matched the measured order for subsequent retries. e.g.: Theoretical: 1) 0.156^0 * 0.844 = 84.4% 2) 0.156^1 * 0.844 = 13.16% 3) 0.156^2 * 0.844 = 2.05% 4) 0.156^3 * 0.844 = 0.32% 5) 0.156^4 * 0.844 = 0.05% Measured: Out of 346 passed programming cycles: The following indicated how many read attempts it took to match the expected image. # Attempt 1 84.40% 292 # Attempt 2 13.00% 45 # Attempt 3 1.73% 6 # Attempt 4 0.87% 3 # Attempt 5 0% 0 Pull Request resolved: facebookexternal/openbmc.arista#120 Reviewed By: mikechoifb fbshipit-source-id: c365e5d741

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The return value of 'sscanf()' should be checked #120

The return value of 'sscanf()' should be checked #120

QiAnXinCodeSafe commented May 27, 2020

The return value of 'sscanf()' should be checked #120

The return value of 'sscanf()' should be checked #120

Comments

QiAnXinCodeSafe commented May 27, 2020