-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defining a Model class for ModelListGP #2529
Comments
Thanks for asking this! Let me follow up internally to see who might be best to answer. |
So the issue here is that by default Ax will select a (batched) non-model-list model that is incompatible with the decoupled acquisition function that There is a way to avoid using batched models by passing in
However, I'm running into some weird issues with this, so I for now just hacked my way around it, see #2514 (comment) - that again surfaced a more serious limitation, see that comment. |
A small correction on the
|
Let me test this out @saitcakmak , thanks a lot! |
@Abrikosoff, did @saitcakmak's solution work out? Please close the issue if you are all set : ) |
I have been trying to run a Service version of
qMultiFidelityHypervolumeKnowledgeGradient
; related thread I have already been able to make the input constructor work (I think!), but I keep getting stuck at the requirement forqMultiFidelityHypervolumeKnowledgeGradient
to have aModelListGP
as surrogate: doing this in the GS, for example:gives me the error
ValueError: qMultiFidelityHypervolumeKnowledgeGradient requires using a ModelList
."surrogate": Surrogate(SingleTaskGP)
gives me the same error;"surrogate": Surrogate(ModelListGP)
gives meTypeError: ModelListGP.__init__() got an unexpected keyword argument 'train_X'
, which is mysterious as nowhere do I have this arg in my code (but is probably because something else is trying to pass this to a surrogate object which is not correctly defined here by me)."surrogate": ListSurrogate(SingleTaskGP)
informs me that ListSurrogate is deprecated (got this idea from this issue, which on first glance I would have thought would be the solution to this problem),so the only thing left (I think) is via a custom model definition (like given here), ala doing something like
class SimpleCustomGP(ModelListGP, GPyTorchModel)
:, but I am not sure how this can be properly defined (one model per MultivariateNormal?). Since I am not sure if this would be the correct way to go, I would like to ask this first before proceeding.Thanks for help!
The text was updated successfully, but these errors were encountered: