Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breaking] remove alias exports DefaultContext and EyreContext #135

Open
LeoniePhiline opened this issue Dec 20, 2023 · 1 comment · May be fixed by #181
Open

[breaking] remove alias exports DefaultContext and EyreContext #135

LeoniePhiline opened this issue Dec 20, 2023 · 1 comment · May be fixed by #181
Labels
breaking change Non-urgent breaking changes, probably delay to the next release

Comments

@LeoniePhiline
Copy link
Contributor

The following aliasing exports are unused and can be removed:

#[cfg(feature = "anyhow")]
#[doc(hidden)]
pub use DefaultHandler as DefaultContext;
#[cfg(feature = "anyhow")]
#[doc(hidden)]
pub use EyreHandler as EyreContext;

The aliases might be imported downstream, making this a breaking change.
@LeoniePhiline LeoniePhiline added the breaking change Non-urgent breaking changes, probably delay to the next release label Feb 20, 2024
LeoniePhiline added a commit to LeoniePhiline/eyre that referenced this issue Jun 28, 2024
@LeoniePhiline
chore!: remove alias exports DefaultContext and EyreContext
2dbd5b1 
`DefaultContext` and `EyreContext` exist as
alias exports enabled by the `anyhow` feature.

However, they are unused within `eyre`; neither
are handlers of such names exposed by `anyhow`.

This changeset removes both handler aliases.

Closes [eyre-rs#135][135].

[135]: eyre-rs#135

BREAKING CHANGE: The alias exports are undocumented
                 but nevertheless part of the
                 crate's public API.
@LeoniePhiline LeoniePhiline linked a pull request Jun 28, 2024 that will close this issue
Open
LeoniePhiline added a commit to LeoniePhiline/eyre that referenced this issue Jul 11, 2024
@LeoniePhiline
chore!: remove alias exports DefaultContext and EyreContext
e461b8c 
`DefaultContext` and `EyreContext` exist as
alias exports enabled by the `anyhow` feature.

However, they are unused within `eyre`; neither
are handlers of such names exposed by `anyhow`.

This changeset removes both handler aliases.

Closes [eyre-rs#135][135].

[135]: eyre-rs#135

BREAKING CHANGE: The alias exports are undocumented
                 but nevertheless part of the
                 crate's public API.
@LeoniePhiline
Copy link
Contributor Author

LeoniePhiline commented Nov 5, 2024 •
edited
Loading

Status: #181 is ready for review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Non-urgent breaking changes, probably delay to the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore!: remove alias exports DefaultContext and EyreContext LeoniePhiline/eyre
1 participant
@LeoniePhiline