Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service worker examples incomplete, do not specify the config object or PUBLIC_URL #414

Open
bradjones1 opened this issue Mar 23, 2023 · 0 comments

Comments

@bradjones1
Copy link

Describe the bug

The documentation for the service worker example implementation does not explain the config object, referenced at

export function register(config) {

It's kinda-sorta self-explanatory but isn't utilized in the calling code at

serviceWorkerRegistration.register();

To Reproduce

n/a

Expected behavior

The config object and the required (?) PUBLIC_URL environment variable are documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant