Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce old Docsy-overrides where needed/wanted #813

Open
nate-double-u opened this issue Mar 22, 2024 · 6 comments
Open

Reintroduce old Docsy-overrides where needed/wanted #813

nate-double-u opened this issue Mar 22, 2024 · 6 comments
Assignees

Comments

@nate-double-u
Copy link
Contributor

nate-double-u commented Mar 22, 2024

Follow up to #803, it looks like we've lost the old version warning banner. Do we still want/need it? if so, we should reintroduce it.

Screenshot 2024-03-22 at 2 52 49 PM

There are several overrides that got dropped and could be reintroduced. The majority of them can be found in PR cncf/docsy#2

@nate-double-u
Copy link
Contributor Author

@nate-double-u nate-double-u changed the title Old version banner removed in docsy upgrade Reintroduce old-Docsy overrides where needed/wanted Mar 22, 2024
@nate-double-u nate-double-u changed the title Reintroduce old-Docsy overrides where needed/wanted Reintroduce old Docsy-overrides where needed/wanted Mar 22, 2024
@Sadamingh
Copy link
Contributor

Hi @nate-double-u, if the banner is needed, I can start to work on these. Need information on which versions I have to add those banners. Also, enabling the banners will possibly remove these issues like #837.

/cc @jmhbnz

@moficodes
Copy link
Member

/assign

@jberkus
Copy link
Contributor

jberkus commented Sep 12, 2024

Yes, we still want the warning banners.

@nate-double-u
Copy link
Contributor Author

Need information on which versions I have to add those banners

I think the banners would be needed for all the versions except current. All the previous versions would say something like 'archived,' while the next version would say something like 'proposed.' (I can't remember exactly the specific wording, but that's it in a nutshell)

@jmhbnz
Copy link
Member

jmhbnz commented Sep 26, 2024

The partial for version banner has now been reintroduced, thanks @moficodes!

Are there any other overrides we want to reintroduce or should we close this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants