Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

Random endpoint names are often generated from a negative integer #42

Open
dmarszk opened this issue Dec 18, 2017 · 2 comments
Open

Random endpoint names are often generated from a negative integer #42

dmarszk opened this issue Dec 18, 2017 · 2 comments

Comments

@dmarszk
Copy link
Member

dmarszk commented Dec 18, 2017

Minus sign in an URI is often confusing.
For example:
rmi://192.168.1.1:1025/1025-Ground_MO_Adapter-Action_-1950501845

A fix would narrow down a range of random values to positive integers, in this piece of code:
https://github.com/esa/CCSDS_MO_TRANS/blob/master/CCSDS_MAL_TRANSPORT_GEN/src/main/java/esa/mo/mal/transport/gen/GENTransport.java#L97

@CesarCoelho
Copy link
Contributor

I would actually remove that Random class and use the current time ( with System.currentTimeMillis() ) directly here:
https://github.com/esa/CCSDS_MO_TRANS/blob/master/CCSDS_MAL_TRANSPORT_GEN/src/main/java/esa/mo/mal/transport/gen/GENTransport.java#L870

Would be a cleaner solution!

@CesarCoelho
Copy link
Contributor

CesarCoelho commented Dec 18, 2020

Copied to the new repo!
esa/mo-services-java#2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants