Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to set "whitelisted ips" in ratelimiting #36442

Open
zetaab opened this issue Oct 4, 2024 · 1 comment
Open

Possible to set "whitelisted ips" in ratelimiting #36442

zetaab opened this issue Oct 4, 2024 · 1 comment
Labels
area/http_filter area/ratelimit question Questions that are neither investigations, bugs, nor enhancements

Comments

@zetaab
Copy link

zetaab commented Oct 4, 2024

Title: Set ratelimiting to all cidrs with exceptions

Description:

I have usecase that I should add ratelimiting to all addresses (0.0.0.0/0) EXCEPT few "whitelisted ips". As I see it, it is quite common use case that people want to set rate limits to everything except few internal api ips (whitelist services that should work always, no matter what).

Relevant Links:
https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#envoy-v3-api-msg-config-route-v3-ratelimit-action

currently envoy does not support exceptions to the remote_address matcher. But it could have "not logic"?

@zetaab zetaab added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Oct 4, 2024
@kyessenov
Copy link
Contributor

I think a "composite" filter could help here. You could wrap the enforcement in a conditional filter that limits the application of the enforcement filter.

@kyessenov kyessenov added question Questions that are neither investigations, bugs, nor enhancements area/ratelimit area/http_filter and removed enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/http_filter area/ratelimit question Questions that are neither investigations, bugs, nor enhancements
Projects
None yet
Development

No branches or pull requests

2 participants