Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache filter processSuccessfulValidation assumes body exists #36435

Open
ravenblackx opened this issue Oct 3, 2024 · 0 comments
Open

Cache filter processSuccessfulValidation assumes body exists #36435

ravenblackx opened this issue Oct 3, 2024 · 0 comments
Assignees
@ravenblackx
Labels
area/cache area/http_filter bug

Comments

@ravenblackx
Copy link
Contributor

If a cache entry is headers-only, and handleCacheHitWithValidation occurs, and validation succeeds, I think the cache filter will roll into the "fetch body" path and then fail, instead of doing encodeHeaders(end_stream=true) as it should.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravenblackx ravenblackx

Labels
area/cache area/http_filter bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ravenblackx