Skip to content
This repository has been archived by the owner on Oct 25, 2022. It is now read-only.

Forge: cannot create pull request when using magit forge #74

Open
rezmuh opened this issue Oct 25, 2019 · 1 comment
Open

Forge: cannot create pull request when using magit forge #74

rezmuh opened this issue Oct 25, 2019 · 1 comment

Comments

@rezmuh
Copy link

rezmuh commented Oct 25, 2019

Hi, i'm pretty new to Emacs. I am using doom-emacs (with magit, evil-magit and forge). I saw that forge was supported in evil-magit.

I tried to use forge's create pull request feature. I saw a new buffer opened up and I save the document with :wq. The pull request message file is saved in .git/magit/posts/new-pullreq. However the pull request isn't sent to GitHub.

I raised this issue in Magit forge repo: magit/forge#208 but it looks like the issue was more related to evil-magit (since if I do C-c C-c in new pull-request buffer, the PR is created).

I have no issue with creating new commits though. When i commit, I can still use :wq to save and quit the buffer to create new commits.

Is this a known bug, or did I miss something?

@justbur
Copy link
Member

justbur commented Nov 5, 2019

It's not a bug so much as it's a keybinding that hasn't been created yet. I replied in the issue you created on the forge issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants