Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Try to use translations from Trakt, to improve ForceUseTrakt option #1004

Open
antonsoroko opened this issue Mar 12, 2024 · 1 comment

Comments

@antonsoroko
Copy link

Expected Behavior

Not a bug but a Request for Comments.

Looks like Trakt now supports translations:
https://trakt.docs.apiary.io/#reference/shows/updated-ids/get-all-movie-translations

so we can try to use translations from Trakt - it will be useful for ForceUseTrakt=true - so for Trakt lists we also will have localization (now it is always in english).

although, i am not sure how valuable is this:
even with ForceUseTrakt=true we still go to TMBD for images so it is not faster than ForceUseTrakt=false, it just sometimes have better info (like proper "air date"), and some own info (like "rating").

I guess long time ago (when Trakt provided images) ForceUseTrakt was added to speed up rendering:
elgatito/elementum@7fc6147

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

  • Version used:
  • Environment name and version:
  • Operating System and version:
  • Link to Kodi debug log:
@elgatito
Copy link
Owner

I guess long time ago (when Trakt provided images) ForceUseTrakt was added to speed up rendering:

I can't recall if Trakt was ever providing images through API.

Looks like Trakt now supports translations:

Yes, looks they added translations. But you need to make a separate request to get title/description for your desired language, so it is a separate request per each item. But it can be called only if non-"en" language needed and called to return only required translation (not all of them).

although, i am not sure how valuable is this:

Yes. That is a main question. One thing is not having descriptions/titles localized at all, another is having both and considering source of data to use.

@antonsoroko antonsoroko changed the title RFC: Try to use translations from Trakt, useful for ForceUseTrakt RFC: Try to use translations from Trakt, to improve ForceUseTrakt option Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants