Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename(2) entry handler is invalid #179

Open
fvalasiad opened this issue Apr 12, 2023 · 1 comment · May be fixed by #180
Open

rename(2) entry handler is invalid #179

fvalasiad opened this issue Apr 12, 2023 · 1 comment · May be fixed by #180
Assignees
Labels
bug Something isn't working

Comments

@fvalasiad
Copy link
Collaborator

rename(2) makes changes to our data structures without validation that said system call has exited successfully(something we cannot know before we reach syscall exit).

Generally speaking the whole mechanism feels awkward and I'd rather find a better way to do it. Will look into it.

@fvalasiad fvalasiad added the bug Something isn't working label Apr 12, 2023
@fvalasiad fvalasiad self-assigned this Apr 12, 2023
@fvalasiad
Copy link
Collaborator Author

Well after thinking about it the solution was rather simple:

The only thing that rename_exit cannot access when compared with its rename_entry counterpart is the absolute path of the oldpath. oldpath itself is actually accessible, and the hash is the same as the newpath hash.

Well speaking in terms of absolutepath that is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant