Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash during undo-redo of edited network #15534

Open
palvarezlopez opened this issue Sep 26, 2024 · 2 comments
Open

Crash during undo-redo of edited network #15534

palvarezlopez opened this issue Sep 26, 2024 · 2 comments
Assignees
Labels
a:netedit bug p:important more important than default but not 'critical'
Milestone

Comments

@palvarezlopez
Copy link
Member

palvarezlopez commented Sep 26, 2024

The crash is caused because after inverting all elements, the connections was selected. After the undo-redo, Netedit try to select the conections agains, but it doesn't' exist and generates an error in NBEdge::getConnectionRef(int fromLane, const NBEdge* to, int toLane).

Bug found in test \selection\bugs\ticket2948 (but not related with #2948)

@palvarezlopez palvarezlopez added a:netedit bug p:important more important than default but not 'critical' labels Sep 26, 2024
@palvarezlopez palvarezlopez added this to the 1.21.0 milestone Sep 26, 2024
@palvarezlopez palvarezlopez self-assigned this Sep 26, 2024
@palvarezlopez palvarezlopez changed the title Crash during undo-redo of massive edited network Crash during undo-redo of edited network Sep 27, 2024
@palvarezlopez
Copy link
Member Author

palvarezlopez commented Sep 27, 2024

Sequence:

  1. Create an empty network
  2. Create three junctions connected with two edges
  3. Compute (this create a connection)
  4. Select all elements inverting (this include the connection, and add the selection in undo-stack)
  5. Undo all elements
  6. Recompute (this destroy the NBEdge connection, but not the GNEEdgeConnection)
  7. Redo all. When Netedit try to select the connection again, CRASH, because their associated NBEdge connection doesn't exist

@namdre
Copy link
Contributor

namdre commented Sep 27, 2024

the crash comes faster if you edit an attribute of the connection and then press undo.
It already occurs as far back as 1.2.0

@behrisch behrisch modified the milestones: 1.21.0, 1.22.0 Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:netedit bug p:important more important than default but not 'critical'
Projects
None yet
Development

No branches or pull requests

3 participants