Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider changing imports include name #48

Open
nilslice opened this issue May 16, 2023 · 0 comments
Open

consider changing imports include name #48

nilslice opened this issue May 16, 2023 · 0 comments

Comments

@nilslice
Copy link
Member

After the recent change in #45, we broke a Tezos example: https://github.com/dylibso/modsurfer/actions/runs/4928214424/jobs/8806287884

This is because the checkfile only has a single import, given that the past semantics of imports.include were such that a module had to have at least the specified imports. Now that we've updated this to mean "the module must have a subset of these imports, but no others", the validation fails for this example.

A consideration would be to change the name from includes here to something less restrictive... maybe allow ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant