Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check difficulty in ContextualCheckBlockHeader #957

Open
scravy opened this issue Apr 12, 2019 · 1 comment
Open

Check difficulty in ContextualCheckBlockHeader #957

scravy opened this issue Apr 12, 2019 · 1 comment
Assignees
Milestone

Comments

@scravy
Copy link
Member

scravy commented Apr 12, 2019

LegacyValidationInterface::ContextualCheckBlockHeader does not check difficulty.

#939 might fix that, or a smaller patch can just patch this in.

@Ruteri inintially reported, I'm aware of it, but lets not forget about it.

@dtr-org dtr-org deleted a comment from mergeable bot Apr 12, 2019
@dtr-org dtr-org deleted a comment from mergeable bot Apr 12, 2019
@scravy scravy self-assigned this Apr 12, 2019
@thothd thothd added this to the 0.2 milestone Apr 16, 2019
@scravy
Copy link
Member Author

scravy commented Apr 16, 2019

Actually, whether the difficulty is met is correctly checked in CheckStake, as difficulty affects eligibility of a coin. This check does not rely on nBits in the header. In fact, this value is never read. That is to say, we could actually drop it form the header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants