Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the non portable RID graph in a future release of .NET #90000

Open
ViktorHofer opened this issue Aug 4, 2023 · 10 comments
Open

Delete the non portable RID graph in a future release of .NET #90000

ViktorHofer opened this issue Aug 4, 2023 · 10 comments

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 4, 2023

Follow-up on dotnet/sdk#34279, see discussion in #92211

@ghost
Copy link

ghost commented Aug 4, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow-up on dotnet/sdk#34279

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries, blocking-release

Milestone: 8.0.0

ViktorHofer added a commit that referenced this issue Aug 4, 2023
@ViktorHofer
Copy link
Member Author

cc @tmds @MichaelSimons @dsplaisted

@dsplaisted
Copy link
Member

Do we want to delete this entirely? The SDK still consumes and includes the old runtime graph from dotnet/runtime, and projects can opt in to using it by setting UseRidGraph to true.

@ViktorHofer
Copy link
Member Author

We don't want anyone to mutate the current runtime.json RID graph anymore. It's de-facto frozen. I was under the impression that the full RID graph already moved to the SDK with your recent change. I think we should do that.

@dsplaisted
Copy link
Member

No, so far only the trimmed-down, portable graph has been moved to the SDK. The full RID graph still comes from runtime.

@ViktorHofer
Copy link
Member Author

I see, thanks for the clarification. Any objection to moving it over? We don't want to ship new versions of Microsoft.NetCore.Platforms anymore, nor do we want to have a transport package, only to carry over a checked-in, frozen asset to the sdk repository.

@ViktorHofer
Copy link
Member Author

gentle ping @dsplaisted. Whatever we do, we should do it asap as the cut-off for RC1 is approaching. Would you mind adding the full RID graph into the sdk repository and removing the dependency on Microsoft.NETCore.Platforms?

@dsplaisted
Copy link
Member

I would prefer to wait until .NET 9 to make the changes to runtime if that's OK. The RID changes are coming in kind of late for .NET 8, and I'd prefer to avoid extra churn. This shouldn't affect any runtime or SDK behavior, right, it's just about simplifying the runtime build?

@ViktorHofer
Copy link
Member Author

We want to stop shipping the Microsoft.NETCore.Platforms package to make it clear that the graph is frozen. The package today appears on nuget.org. While we could just make it a transport package for the current release, I wonder if it wouldn't be easier to just move the graph into the sdk repo. I'm fine with either option for .NET 8.

@dsplaisted
Copy link
Member

I would prefer for .NET 8 to just mark it as a transport package, and then remove it for .NET 9.

@ViktorHofer ViktorHofer changed the title Delete Microsoft.NetCore.Platforms projects when consuming an .NET 8 RC1 SDK Delete Microsoft.NetCore.Platforms projects when consuming a .NET 9 SDK Aug 10, 2023
@ViktorHofer ViktorHofer modified the milestones: 8.0.0, 9.0.0 Aug 10, 2023
ViktorHofer added a commit that referenced this issue Aug 10, 2023
The full RID graph is frozen and won't change anymore. Mark the Microsoft.NETCore.Platforms nuget package as non-shipping as only the sdk repository still requires it.

Contributes to #90000
ViktorHofer added a commit that referenced this issue Aug 10, 2023
The full RID graph is frozen and won't change anymore. Mark the Microsoft.NETCore.Platforms nuget package as non-shipping as only the sdk repository still requires it.

Contributes to #90000
@ViktorHofer ViktorHofer changed the title Delete Microsoft.NetCore.Platforms projects when consuming a .NET 9 SDK Delete the non portable RID graph in a future release of .NET Sep 19, 2023
@ViktorHofer ViktorHofer removed their assignment Sep 19, 2023
@ViktorHofer ViktorHofer modified the milestones: 9.0.0, Future Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants