-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pull_comment.created addressed by issue_comment.created or not ? #20
Comments
there are two types of "pull request comments":
|
@dontcallmedom wrote:
yeah, thx, that's what I figured out by observation. Though, today, I made comments on a couple PRs that were not (as yet?) fwd'd to the public-webauthn@ list:
..so there's some issue(s) somewhere(s). I note that PR comments have been fwd'd to the public-webauthn@ list in the past, so I'm wondering why this behavior appeared today... @dontcallmedom also wrote:
It would be very nice IMV to have the option to have such comments -- both individual line-comments, as well as PR "review (both summary and line) comments" -- fwd'd to a mailing list. thanks, =JeffH |
@equalsJeffH wrote
Indeed, there seems to have been a problem with part of what the system expects from the github API around the time you sent these messages. I'm not sure if there is much that can be done about it.
right; I'll try to get to this soon, but of course, pull requests are very welcome if you feel like diving in this :) |
Are pull request comments covered by issue_comment.created -- ie are PR comments forwarded to the mailing list if the latter event is selected ? Or, might we need yet another template established for pull_comment.created in order to do so? I am guessing the latter is the case, based on what is being sent to the public-webauthn@ list via github.com/w3c/webauthn/.
thx
The text was updated successfully, but these errors were encountered: