From 90cb7bbe525047f9710e6735e55e6e014569a149 Mon Sep 17 00:00:00 2001 From: Ned Twigg Date: Sun, 13 Oct 2024 00:39:59 -0700 Subject: [PATCH] Fix spotbugs. --- .../com/diffplug/spotless/ConfigurationCacheHackList.java | 1 + .../spotless/FormatterStepSerializationRoundtrip.java | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/lib/src/main/java/com/diffplug/spotless/ConfigurationCacheHackList.java b/lib/src/main/java/com/diffplug/spotless/ConfigurationCacheHackList.java index ac2f34431..6bbc6ff2a 100644 --- a/lib/src/main/java/com/diffplug/spotless/ConfigurationCacheHackList.java +++ b/lib/src/main/java/com/diffplug/spotless/ConfigurationCacheHackList.java @@ -47,6 +47,7 @@ * to make Spotless work with all of Gradle's cache systems at once. */ public class ConfigurationCacheHackList implements java.io.Serializable { + private static final long serialVersionUID = 1L; private final boolean optimizeForEquality; private final ArrayList backingList = new ArrayList<>(); diff --git a/lib/src/main/java/com/diffplug/spotless/FormatterStepSerializationRoundtrip.java b/lib/src/main/java/com/diffplug/spotless/FormatterStepSerializationRoundtrip.java index edc8dd67c..d2f0e4b5b 100644 --- a/lib/src/main/java/com/diffplug/spotless/FormatterStepSerializationRoundtrip.java +++ b/lib/src/main/java/com/diffplug/spotless/FormatterStepSerializationRoundtrip.java @@ -20,10 +20,12 @@ import java.util.Objects; import edu.umd.cs.findbugs.annotations.Nullable; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; final class FormatterStepSerializationRoundtrip extends FormatterStepEqualityOnStateSerialization { private static final long serialVersionUID = 1L; private final String name; + @SuppressFBWarnings(value = "SE_TRANSIENT_FIELD_NOT_RESTORED", justification = "HackClone") private final transient ThrowingEx.Supplier initializer; private @Nullable RoundtripState roundtripStateInternal; private @Nullable EqualityState equalityStateInternal; @@ -74,6 +76,8 @@ protected FormatterFunc stateToFormatter(EqualityState equalityState) throws Exc * It works in conjunction with ConfigurationCacheHackList to allow Spotless to work with all of Gradle's cache systems. */ static class HackClone implements Serializable { + private static final long serialVersionUID = 1L; + @SuppressFBWarnings(value = "SE_TRANSIENT_FIELD_NOT_RESTORED", justification = "HackClone") transient FormatterStepSerializationRoundtrip original; boolean optimizeForEquality; @Nullable @@ -84,6 +88,7 @@ static class HackClone