Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

A wrong label is assigned #140

Closed
php-coder opened this issue Aug 16, 2018 · 5 comments
Closed

A wrong label is assigned #140

php-coder opened this issue Aug 16, 2018 · 5 comments

Comments

@php-coder
Copy link

The issues created by Dependabot has a wrong label -- dependency/spring. I'm using this label for marking issues that are related to Spring Framework. If Dependabot need some particular label, it should be stated as a requirement in the installation manual. Also, it should be configurable in UI.

Examples:
php-coder/mystamps#936
php-coder/mystamps#937
php-coder/mystamps#938
php-coder/mystamps#939
php-coder/mystamps#940

Thank you!

@greysteil
Copy link
Contributor

Ah, oops! Dependabot looks for labels in your repo that includes dependency and uses them in place of its own dependencies label if they exist, in an attempt to match your style. Obviously its made the wrong decision here! I'll get that fixed.

@php-coder
Copy link
Author

@greysteil Thank you for the fast reply! How it will work after fix? Do I need to create a dedicated label myself or Dependabot will create it? Or it will create issues without label if it doesn't exist in a repo?

@greysteil
Copy link
Contributor

I think the fix here is for Dependabot to explicitly ignore that label when looking at labels users might prefer to Dependabot's default dependencies label. Once I've deployed that Dependabot will correctly create a dependencies label and start labelling its PRs with that. If you'd prefer it use a different label, or no label at all, you can just label up a Dependabot PR how you'd like it and then comment @dependabot use these labels.

@greysteil
Copy link
Contributor

The code is here btw.

@greysteil
Copy link
Contributor

Fixed in dependabot/dependabot-core@063f67f. Thanks for reporting!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants