Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letterboxing & pillarboxing issue #248

Open
wesort opened this issue May 3, 2017 · 0 comments
Open

Letterboxing & pillarboxing issue #248

wesort opened this issue May 3, 2017 · 0 comments

Comments

@wesort
Copy link

wesort commented May 3, 2017

I've been using Fitvids successfully on projects for years, but I've found an issue with Vimeo embeds either letterboxing (black lines above & below) or pillarboxing (black lines left & right) on certain videos. This appears at first, but will then disappear if the viewport is resized or rotated.

  • Example: http://theo.wetest.co.uk/work/option-1
  • JS code use direct from master and I've renamed #thing-with-videos to .media-container (those are the only code changes)
  • Tested with all other JS removed and tried unfloating the containers
  • This is on a static site and the issue is present on the 2 devices (Chromebook Pixel & Nexus 5X) I've used to test.

Screenshot of initial page load showing issue:
initial-page-load

Screenshot after viewport resize:
after-viewport-resize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant