Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FitVids.js not working on iPad #218

Open
RenegadeMonster opened this issue Aug 7, 2015 · 8 comments
Open

FitVids.js not working on iPad #218

RenegadeMonster opened this issue Aug 7, 2015 · 8 comments

Comments

@RenegadeMonster
Copy link

I am developing a site off of the Totomo Wordpress theme, which uses FitVids.js to display videos in the featured image area above the post when a post has a post type of "Video".

On my iMac with Safari, Chrome and Firefox FitVids.js works perfectly no mater what size I have my browser window right down to as small as I can drag it. Fit vid also works perfectly on my iPhone in both landscape and portrait mode.

However, I have found when viewing the page on my iPad YouTube videos (Haven't tried any videos from any other source) do not resize. They are to small for the space available, and hang out on the left side. This happens in both landscape and portrait mode. It's almost as if the videos are being set to a fixed width for mobile / phones and are not sizing correctly for iPad / tables and certainly not expanding to fit to fit to the space available.

I was wondering if anyone has run into this and have any advice or solutions for this issue.

Thanks

@davatron5000
Copy link
Owner

Without a Reduced Test Case we'll be unable to diagnose the issue.

@RenegadeMonster
Copy link
Author

What do you mean by a reduced test case?

@davatron5000
Copy link
Owner

Please read this: https://github.com/davatron5000/FitVids.js/blob/master/CONTRIBUTING.md

You've described a problem to me and right now I have no code, no urls, no 3rd party video vendors, no iOS version numbers, nothing to go off of, so it's hard to debug your situation. It could be something wrong with WordPress or a certain type of video. Making a reduced test case (the smallest amount of code possible that replicates the issue) helps diagnose the bug.

Any more information would be great.

@RenegadeMonster
Copy link
Author

Working on trying to to get it to work with codepen with as little code as possible, not sure if I will get it.

But the site I am working on is http://www.againstthecurrent.rocks

The issue happens on both iOS 8.4 and 9.0 Public Beta 2

Once I get the information you need do I need to post a new issue, or would this one be reopened?

The third party video vender would YouTube.

@RenegadeMonster
Copy link
Author

OK, here is a codepen example: http://codepen.io/RenegadeMonster/pen/oXVXad

Although, in this example the YouTube video doesn't size correctly only in portrait. Landscape works fine here but when in portrait mode the video is sized at the width for Landscape mode.

Codepen: http://codepen.io/RenegadeMonster/pen/oXVXad
Codepen fullpage view: http://codepen.io/RenegadeMonster/full/oXVXad/

I tested this on a iPad Air 2, iOS 9.0 Public Beta 2 and a iPad 3rd Generation iOS 8.4.

Sizing works fine on my iPhone 6+ in both portrait and landscape with iOS 9.0 Public Beta 2

@RenegadeMonster
Copy link
Author

Just checking in, do I need to create a new issue request or can this issue be reopened?

@kurtwaldo
Copy link

@RenegadeMonster Was this ever solved?

@davatron5000 davatron5000 reopened this Jan 11, 2016
@davatron5000
Copy link
Owner

Does adding the meta viewport solve the issue?

<meta name="viewport" content="width=device-width, initial-scale=1">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants