div injected inside head tag, and whitespace issues on generated css

[toddmotto]

As per screenshot, a div is injected into the head element, which is wrong. I'd suggest opting for an attribute/attrs on <style> such as <style id="fitvids">.

Once rendered in the DOM, you've got a lot of whitespace, a simple /\s/g replace before appending would solve this for anyone debugging/viewing the code in Dev Tools:

[davatron5000]

1. The whitespace issue should have been addressed. Are you using the latest version?
2. The div injection is necessary due to a scope issue in IE

[toddmotto]

Just inspecting element on fitvidsjs.com. And that's interesting, what's the scope issue w/IE?

[toddmotto]

Ah, that'll teach me for reading messages without looking at the hyperlink ;) haha... Have you looked at either:

IE:
style.styleSheet.cssText = css;

All others:
document.createTextNode(css)

[davatron5000]

It hasn't come up, because what we have is working. I suppose it's possible (??). It would just require a pretty big round of testing to make sure.

[toddmotto]

Yeah, it would definitely be an improvement, injecting into the DOM as a string isn't always perfect. I don't know if you've seen FluidVids, but it's a raw JS equivalent, which makes use of this technique (just pushed an update): https://github.com/toddmotto/fluidvids/blob/master/dist/fluidvids.js. Feel free to integrate into FitVids the few lines of code.

[davatron5000]

Nice! Might do. Let me know if run into any problems. 

—
Sent from Mailbox for iPhone

On Wed, Oct 30, 2013 at 5:21 PM, Todd Motto [email protected]
wrote:

Yeah, it would definitely be an improvement, injecting into the DOM as a string isn't always perfect. I don't know if you've seen FluidVids, but it's a raw JS equivalent, which makes use of this technique (just pushed an update): https://github.com/toddmotto/fluidvids/blob/master/dist/fluidvids.js. Feel free to integrate into FitVids the few lines of code.

Reply to this email directly or view it on GitHub:
#144 (comment)

[davatron5000]

Merging this into #159