Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving to file-based configuration for the proxy instead of using environment variables #94

Open
alicel opened this issue Jan 11, 2023 · 0 comments

Comments

@alicel
Copy link
Collaborator

alicel commented Jan 11, 2023

The proxy is currently configured through a set of environment variables. While this has been a great way to get the project going, it is not ideal from a practical point of view (especially for users who choose to deploy the proxy without using our Ansible automation) and raises some security concerns (storing sensitive values in environment variables is generally not recommended and can be an issue for security-conscious users).

We should consider moving to file-based configuration for the proxy, which has the following advantages:

  • Easier to configure and populate for users who wish to configure the proxy directly
  • The configuration can be easily viewed in a structured way
  • We can group logically related variables into buckets
  • Access to the configuration can be restricted by setting OS permissions on the file appropriately

The configuration is currently parsed at proxy startup and does not subsequently change. Replacing the env var parsing logic with file-based parsing should not be particularly challenging.

The main effort will be:

  • Choosing the right format for the configuration file, which should allow us to represent hierarchical groups without making the syntax complex or fiddly.
  • Structuring the configuration in the right hierarchy (although a lot of this work has already been done with the config API overhaul for 2.0, in which we streamlined the config variables, renamed them in a more consistent way and organised them into groups).

┆Issue is synchronized with this Jira Task by Unito
┆Components: Proxy
┆Issue Number: ZDM-516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant