Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude OPTIONS messages from metrics #103

Open
alicel opened this issue Feb 23, 2023 · 1 comment
Open

Exclude OPTIONS messages from metrics #103

alicel opened this issue Feb 23, 2023 · 1 comment

Comments

@alicel
Copy link
Collaborator

alicel commented Feb 23, 2023

Aside from being used to negotiate supported features in some , OPTIONS messages are sometimes used as a heartbeat / keepalive mechanism by some drivers.

At the moment the proxy handles OPTIONS messages as generic messages, routing them to both clusters and tracking them into "forward to both" metrics, which typically represent writes. Seeing OPTIONS counted and displayed in metrics labelled as writes can be confusing, especially when running small manual tests where these "spurious" requests are not drowned out by legitimate write activity.

We should exclude OPTIONS from the messages that are tracked in the metrics, similarly to what we do for other messages such as STARTUP and REGISTER.

┆Issue is synchronized with this Jira Task by Unito
┆Components: Proxy
┆Issue Number: ZDM-541

@sync-by-unito
Copy link

sync-by-unito bot commented Mar 1, 2023

➤ Wei Deng commented:

For now, we can add a new troubleshooting tip, before the new metrics are implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant