Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User email prompt/collection issue #479

Open
deraj1013 opened this issue Aug 12, 2020 · 10 comments
Open

User email prompt/collection issue #479

deraj1013 opened this issue Aug 12, 2020 · 10 comments

Comments

@deraj1013
Copy link

A user reported an issue with the email collection prompt that I was able to duplicate in incognito mode in my browser with an email that has not been used to sign up for the database. Essentially, when the user hits a maximum allowable search, it prompts him to enter his email. He does, and then the prompt tells him to check his email for a verification message.

I was under the impression that the email information was now being handled through a cookie rather than the email verification. Let me know if I'm wrong, and if you have any idea what the problem is here. Also, if you need more information from me, let me know.

image009
image008
image007

@deraj1013
Copy link
Author

Also, let me know if this is a problem with Salsa on our end.

@hancush
Copy link
Member

hancush commented Aug 12, 2020

@deraj1013 This is the expected behavior. I will send you testing instructions that outline the full spec via email, as they contain the login for the staging site.

@deraj1013
Copy link
Author

I'll check through the instructions. The user (and I) are not getting the verification email. That's not how it's supposed to work, is it?

@hancush
Copy link
Member

hancush commented Aug 12, 2020

If there is no email, then things aren't working as expected. I will open an email thread with you and John, as we will need some budget to debug and repair the issue.

@deraj1013
Copy link
Author

Sounds good

@deraj1013
Copy link
Author

So it looks like the email came through to my account about four hours after I submitted it. It may be an issue on the end of our user rather than the system.

@hancush
Copy link
Member

hancush commented Aug 18, 2020

The same thing happened to me, when I resubmitted my email as a test! Think the message came through the next day. Picking this up now, @deraj1013.

@hancush
Copy link
Member

hancush commented Sep 21, 2020

TODO: Swap in SendGrid creds prior to launch.

@hancush
Copy link
Member

hancush commented Sep 21, 2020

For posterity, this was mostly addressed by datamade/django-salsa-auth#9.

@hancush
Copy link
Member

hancush commented Sep 23, 2020

Update: We've switched over to SendGrid for the launch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants