Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some URN inconsistencies #154

Open
abhi4578 opened this issue Nov 9, 2021 · 1 comment
Open

Some URN inconsistencies #154

abhi4578 opened this issue Nov 9, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@abhi4578
Copy link
Contributor

abhi4578 commented Nov 9, 2021

Some URN inconsistencies I found while testing

  1. MethodNotAllowed for not proper method requested, eg: requesting apidocs using TRACK method, refer
    curl -XTRACK https://rs.iudx.org.in/apis -vvv
    Response : response code : 404, json recieved: {"type":"urn:dx:rs:general","title":"Not Found","detail":"Not Found"}
    Expected : It should be something like response code : 405, json-recieved {"type":"urn:dx:rs:MethodNotAllowed","title":"Method Not Allowed","detail":"Specified method is invalid for this resource"}
  2. Latest data search/spatial search
    json response: { "type": 200, "title": "Success", "results": [ ] }
    expected json response must be like :
{
"type": "urn:dx:rs:Success",
"title":"",
"results": [
{
"id": "resource-id-xyz-abc"
}
]
}
  1. Capitalisation of first letter in type . Eg: "type":"urn:dx:rs:general" should be "type":"urn:dx:rs:General"
    Please do refer the urn response defined in draft BIS Standard: IS 18003 (Part 2):2021 Doc No: LITD 28 (17249), Unified Data Exchange Part 2: API specifications.
    @kailash @swaminathanvasanth
@abhi4578
Copy link
Contributor Author

abhi4578 commented Nov 9, 2021

  1. Some response are directly given by gateway nginx and is not proxied to vertx. Do we want that too to follow urn responses ? @swaminathanvasanth . This includes following:
  • 500 internal server error
  • 502 bad gateway. This can appear while autoscalling of api servers or api servers are done for some reason.
  • 429 Too many requests per ip and total requests to server
  • 400 bad request method : curl -XtRACK https://rs.iudx.org.in/apis -vvv
  • 431 Request Header Fields Too Large
  • 414 Request-URI Too Long
  • 308 Permanent redirection : curl http://rs.iudx.org.in/apis -vvv
  • etc, other 3xx,4xx,5xx refer

@abhi4578 abhi4578 added the bug Something isn't working label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant