Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define the workshop directory #529

Open
goi42 opened this issue Mar 1, 2023 · 3 comments
Open

define the workshop directory #529

goi42 opened this issue Mar 1, 2023 · 3 comments
Assignees
Labels
status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR type:typo text Typo in text for the lesson,

Comments

@goi42
Copy link
Contributor

goi42 commented Mar 1, 2023

In Starting With Data, learners are instructed to navigate to "the workshop directory". This phrase has not been defined in the Setup or any of the earlier lessons, as far as I can tell.

My best guess is that this refers to the zip file that can be downloaded from the Setup page, but this doesn't follow the guidance in Before we start, which suggests data be stored in the data/ subdirectory.

I think the lesson wants the learners to create an empty directory for the workshop, create a subdirectory inside it called data/, then move the downloaded files into it. If so, learners should be stepped through this process explicitly to avoid confusion.

@goi42
Copy link
Contributor Author

goi42 commented Mar 3, 2023

df_na.to_csv('data_output/surveys_complete.csv', index=False)

The Writing Out Data to CSV exercise fails with an OSError because the data_output/ directory does not exist.

Either this subdirectory should be created as part of defining the workshop directory in an earlier lesson (as described above), or instructions should be added to the lesson for how to create this subdirectory.

@goi42
Copy link
Contributor Author

goi42 commented Mar 3, 2023

Lesson 5 repeats the Writing Out Data to CSV exercise using concatenated data frames, but this time stores the output in the data/ subdirectory instead of data_output.

It would be better to be consistent across these exercises, especially since the Before we start lesson makes a point of maintaining good directory organization.

@btovar
Copy link
Contributor

btovar commented Apr 24, 2023

@goi42 I agree with you about the consistency of data and data_output. Would you like to make a pull request to fix this one?

@btovar btovar self-assigned this Apr 24, 2023
@btovar btovar added status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR type:typo text Typo in text for the lesson, labels Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:waiting for response Waiting for Contributor to respond to maintainers' comments or update PR type:typo text Typo in text for the lesson,
Projects
None yet
Development

No branches or pull requests

2 participants